Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18124 )
Change subject: KUDU-2915: add tool to remove a tablet server ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc@7490 PS1, Line 7490: ASSERT_STR_CONTAINS(out, ts_uuid); nit: ts_uuid would be present in the ksck no matter what. Probably check for a string like ts_uuid | ts_hostname:port | Unavailable Same below http://gerrit.cloudera.org:8080/#/c/18124/1/src/kudu/tools/kudu-tool-test.cc@7536 PS1, Line 7536: We could force remove the tserver Do we want to run the tool without the flag -force_remove_live_tserver and ensure it errors out if the tserver is not marked as dead? -- To view, visit http://gerrit.cloudera.org:8080/18124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f5c2979a8d14428f4bcc8e850c57ce228c793a Gerrit-Change-Number: 18124 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 10 Jan 2022 16:44:37 +0000 Gerrit-HasComments: Yes
