Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18121 )
Change subject: [tools] Kudu table schema in Avro format ...................................................................... Patch Set 2: (5 comments) Mostly minor comments. http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/kudu-admin-test.cc@1914 PS2, Line 1914: =true nit: not needed http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/tool_action_table.cc@129 PS2, Line 129: "Display the table schema in avro format. When enabled it only outputs the " : "table schema in Avro format. It cannot be used in conjunction with other flags"); Indentation. Perhaps it'd be good to mention, without partition information. http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/tool_action_table.cc@249 PS2, Line 249: " Nit: Indentation http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/tool_action_table.cc@257 PS2, Line 257: Nit: Remove blank line http://gerrit.cloudera.org:8080/#/c/18121/2/src/kudu/tools/tool_action_table.cc@325 PS2, Line 325: !fLB::FLAGS_show_avro_format_schema Looks like indentation has changed the formatting below. Is fLB needed? If (FLAGS_show_avro_format_schema) { return PopulateAvroSchema() } -- To view, visit http://gerrit.cloudera.org:8080/18121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075 Gerrit-Change-Number: 18121 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jan 2022 20:59:32 +0000 Gerrit-HasComments: Yes
