Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18121 )
Change subject: [tools] Kudu table schema in Avro format ...................................................................... Patch Set 6: (4 comments) Thanks for the feedback. Posting a new patch to address these comments. http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc@1923 PS6, Line 1923: " \"name\": \"table\",\n" : " \"type\": \"TestAnotherTable\",\n" > Should these two values for the 'name' and 'type' fields be swapped? In ot Yes, that will be rectified in the follow-up patch. http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc@1944 PS6, Line 1944: " \"name\": \"int8_val\",\n" : " \"type\": \"int\"\n" > Here and below for nullable fields: should the printout for a field include We can print the default value and the nullability of a column http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc@254 PS6, Line 254: & > nit for here and below: stick the ampersand to the type Done http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc@311 PS6, Line 311: } > For the sake of catching cases when a new data type is added, consider addi Done -- To view, visit http://gerrit.cloudera.org:8080/18121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075 Gerrit-Change-Number: 18121 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 14 Jan 2022 00:03:44 +0000 Gerrit-HasComments: Yes
