Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18121 )
Change subject: [tools] Kudu table schema in Avro format ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18121/3/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18121/3/src/kudu/tools/tool_action_table.cc@331 PS3, Line 331: & Nit: This and few places below, the & was moved from auto to the var name due to formatting. It'd be better to use if (FLAGS_show_avro_format_schema) instead and return PopulateAvroSchema() directly avoiding indentation. -- To view, visit http://gerrit.cloudera.org:8080/18121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075 Gerrit-Change-Number: 18121 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jan 2022 23:27:21 +0000 Gerrit-HasComments: Yes
