Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18121 )
Change subject: [tools] Kudu table schema in Avro format ...................................................................... Patch Set 6: (4 comments) I'm a bit late for the party, but I left some feedback as well. Feel free to address that in a follow-up changelist or simply ignore that :) http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc@1923 PS6, Line 1923: " \"name\": \"table\",\n" : " \"type\": \"TestAnotherTable\",\n" Should these two values for the 'name' and 'type' fields be swapped? In other words, I'd expect something like "type": "table", "name": "TestAnotherTable", instead. http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/kudu-admin-test.cc@1944 PS6, Line 1944: " \"name\": \"int8_val\",\n" : " \"type\": \"int\"\n" Here and below for nullable fields: should the printout for a field include * the default value * the nullability of the field? http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc@254 PS6, Line 254: & nit for here and below: stick the ampersand to the type http://gerrit.cloudera.org:8080/#/c/18121/6/src/kudu/tools/tool_action_table.cc@311 PS6, Line 311: } For the sake of catching cases when a new data type is added, consider adding LOG(DFATAL) for the 'default' case. -- To view, visit http://gerrit.cloudera.org:8080/18121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98194739e8132f93e916d1a78d338d28dd9e8075 Gerrit-Change-Number: 18121 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 11 Jan 2022 21:41:57 +0000 Gerrit-HasComments: Yes
