Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [security] KUDU-3331 Encrypt file system ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc@106 PS9, Line 106: IsFileEncrypted > You're right, temp files would cause a problem with this approach. I guess Sure. Just making sure I understand your proposal: for each file we'll always try to read an encryption header, and if we can deserialize one for whatever reason, we'll assume there was no encryption and read decrypted. Is that the case? http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/util/pb_util-test.cc File src/kudu/util/pb_util-test.cc: PS9: > I wanted to figure out the expected behavior of the IsFileEncrypted before I was thinking a pb-specific test, to ensure other developers can know what to expect when using the SensitivityModes. -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jan 2022 06:17:20 +0000 Gerrit-HasComments: Yes
