Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17974 )
Change subject: [security] KUDU-3331 Encrypt file system ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/tools/tool_action_pbc.cc@106 PS9, Line 106: IsFileEncrypted > Sure. Just making sure I understand your proposal: for each file we'll alwa Basically, yes. http://gerrit.cloudera.org:8080/#/c/17974/9/src/kudu/util/pb_util-test.cc File src/kudu/util/pb_util-test.cc: PS9: > I was thinking a pb-specific test, to ensure other developers can know what Ok, I'll add one to the encryption header patch then. -- To view, visit http://gerrit.cloudera.org:8080/17974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d0c4af0c1fca0d14c99a6627842dbe2ed7524 Gerrit-Change-Number: 17974 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jan 2022 07:59:27 +0000 Gerrit-HasComments: Yes
