Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 14: Code-Review+1 (5 comments) Looks fine, barring some nits and one more thought regarding logical size implementation http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG@33 PS14, Line 33: With encryption enabled, extra : steps are necessary to align the first block, and aligning blocks makes : it impractical to hide encryption header size within Env and use : logical file sizes outside of it. One thought here is: could we still do the extra steps mentioned, and still use logical size? E.g. write the header and update the next block to be logical offset (4k - header_size)? http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc@2167 PS14, Line 2167: nit: there should be 4 spaces after the previous lines for continuations http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc@2209 PS14, Line 2209: ? nit: funny spacing http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tserver/tablet_copy_service-test.cc@395 PS14, Line 395: nit: spacing http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/util/env_posix.cc@850 PS14, Line 850: ceil(key_size / 16.) * 16) Seems we should be able to do this with some bitwise operations. -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 28 Jan 2022 19:23:28 +0000 Gerrit-HasComments: Yes
