Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18025 )
Change subject: [security] KUDU-3316 Add encrypted file keys ...................................................................... Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18025/14//COMMIT_MSG@33 PS14, Line 33: With encryption enabled, extra : steps are necessary to align the first block, and aligning blocks makes : it impractical to hide encryption header size within Env and use : logical file sizes outside of it. > One thought here is: could we still do the extra steps mentioned, and still Technically, I think it would be possible. I started to work on a POC to see what this would look like, but unfortunately, so far it looks like we would gain nothing with this approach, as it would simplify some parts, but complicate others. Not sure if it's worth pursuing this, at least not right now. As this is not part of the public API, we can change the contract later if we decide to refactor it. http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc@2167 PS14, Line 2167: > nit: there should be 4 spaces after the previous lines for continuations Done http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tools/kudu-tool-test.cc@2209 PS14, Line 2209: ? > nit: funny spacing Done http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: http://gerrit.cloudera.org:8080/#/c/18025/14/src/kudu/tserver/tablet_copy_service-test.cc@395 PS14, Line 395: > nit: spacing Done -- To view, visit http://gerrit.cloudera.org:8080/18025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb1282c117271fda63a8cc54c00add7cc96dcffd Gerrit-Change-Number: 18025 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 29 Jan 2022 00:03:40 +0000 Gerrit-HasComments: Yes
