Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 )
Change subject: [master] Add a rebalance request/response and provide a tool, refact master's rebalance ...................................................................... Patch Set 14: (3 comments) Not a full review, just thought I'd put in the request to break this up http://gerrit.cloudera.org:8080/#/c/18402/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18402/14//COMMIT_MSG@8 PS14, Line 8: : 1. Refact master's auto rebalance, enable/disable auto rebalancer : need not restart master. : : 2. Add a rebalance request/response, user can trigger rebalance task, : even if the rebalancer is disabled. : : 3. Add a new rebalance tool, and compatible with incoming's leader : rebalance. : Thanks for all these changes! But please split these into individual patches with unit tests for each logical behavior. It will be much easier for reviewers to review that way. http://gerrit.cloudera.org:8080/#/c/18402/14/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18402/14/src/kudu/master/auto_rebalancer.cc@277 PS14, Line 277: #define NEXT_EXECUTE_FUNCTION \ This is never called, it seems. http://gerrit.cloudera.org:8080/#/c/18402/14/src/kudu/master/auto_rebalancer.cc@300 PS14, Line 300: if (moves_scheduled_this_round_for_test_ == 0) { : // To Avoid double leaders. : SleepFor(MonoDelta::FromMilliseconds(5 * FLAGS_raft_heartbeat_interval_ms)); : } What was the behavioral change that led to this? I expected there to be few functional changes in this patch. -- To view, visit http://gerrit.cloudera.org:8080/18402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946 Gerrit-Change-Number: 18402 Gerrit-PatchSet: 14 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 07 May 2022 07:09:53 +0000 Gerrit-HasComments: Yes
