Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 )
Change subject: [master] Add a rebalance request/response and provide a tool, refact master's rebalance ...................................................................... Patch Set 15: (5 comments) Thanks you crs. I will adopt your advices, split it into serval indepent crs. http://gerrit.cloudera.org:8080/#/c/18402/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18402/14//COMMIT_MSG@8 PS14, Line 8: : 1. Refact master's auto rebalance, enable/disable auto rebalancer : need not restart master. : : 2. Add a rebalance request/response, user can trigger rebalance task, : even if the rebalancer is disabled. : : 3. Add a new rebalance tool, and compatible with incoming's leader : rebalance. : > Thanks for all these changes! But please split these into individual patche Thanks your advices. I'll do it. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/auto_rebalancer.h@84 PS15, Line 84: DataRebalance > If that's about rebalancing replica distribution, why to call this 'DataReb ReplicaRebalance ok? http://gerrit.cloudera.org:8080/#/c/18402/14/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18402/14/src/kudu/master/auto_rebalancer.cc@277 PS14, Line 277: if (!FLAGS_auto_rebalancing_enabled) { > This is never called, it seems. Sorry, I forget remove it. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto@849 PS15, Line 849: DATA_REBALANCE > This naming is misleading -- current rebalancing isn't data rebalancing, it I see. I can change it. The purpose is data rebalance, but the implements just use rebalance number of replicas to reach approximate effect. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto@859 PS15, Line 859: required int64 task_id = 1; > What purpose does 'task_id' have in this message and what its significance? the task is async execution. so we should have a method to check if the task is finished. -- To view, visit http://gerrit.cloudera.org:8080/18402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946 Gerrit-Change-Number: 18402 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:30:54 +0000 Gerrit-HasComments: Yes
