Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18402 )
Change subject: [master] Add a rebalance request/response and provide a tool, refact master's rebalance ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/18402/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18402/15//COMMIT_MSG@12 PS15, Line 12: 2. Add a rebalance request/response, user can trigger rebalance task, : even if the rebalancer is disabled. Why to introduce it at all? What's the purpose? I'm not sure I can see the explanation here. With current rebalancer tool, you can do rebalancing right now without those extras. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/auto_rebalancer.h@84 PS15, Line 84: DataRebalance If that's about rebalancing replica distribution, why to call this 'DataRebalance'? Seems a bit misleading to me. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto@849 PS15, Line 849: DATA_REBALANCE This naming is misleading -- current rebalancing isn't data rebalancing, it simply evens out replica distribution in terms of number of those per tablet server. That's not data rebalancing per se, not at all. http://gerrit.cloudera.org:8080/#/c/18402/15/src/kudu/master/master.proto@859 PS15, Line 859: required int64 task_id = 1; What purpose does 'task_id' have in this message and what its significance? Does it bring some info on the error happened, as per the comment above? This looks a bit strange. -- To view, visit http://gerrit.cloudera.org:8080/18402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d506d877662c029a30dca9dd5029b9da4162946 Gerrit-Change-Number: 18402 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 20 May 2022 16:32:17 +0000 Gerrit-HasComments: Yes
