Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: Batch set master/tserver flags ...................................................................... Patch Set 1: (2 comments) The clang-tidy and IWYU checks failed, you can run these checks locally and fix them. See https://github.com/apache/kudu#running-clang-tidy-checks and https://github.com/apache/kudu#running-include-what-you-use-iwyu-checks for details. http://gerrit.cloudera.org:8080/#/c/18506/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18506/1//COMMIT_MSG@7 PS1, Line 7: Batch set master/tserver flags nit: Could you please add some description about what tools have been added and how these tools can be used? http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_master.cc@793 PS1, Line 793: .AddRequiredParameter({ kValueArg, "New value for the gflag" }) Maybe we also need to provide an optional parameter 'force' here just as the set_flag tool. -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 09 May 2022 15:07:53 +0000 Gerrit-HasComments: Yes
