Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 6: (16 comments) > Patch Set 4: > > (16 comments) done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc@18 PS4, Line 18: #include <sys/stat. > Switch to using ASSERT_TRUE() from assert() and remove this header. Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc@1197 PS4, Line 1197: }; > nit: it's better to keep this sorted alphabetically -- move this new string Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc@1374 PS4, Line 1374: }; > nit: keep it sorted Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc@8109 PS4, Line 8109: TEST_P(SetClusterFlagTest, IsMaster) { > It would be great to add a test scenario to make sure that the new tools re Ok. Add a new test for setting non-existed flag http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/kudu-tool-test.cc@8156 PS4, Line 8156: return; > here and below: don't use assert in tests, use ASSERT_TRUE() instead Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@152 PS4, Line 152: > I guess this list should be retrieved from the leader master instead of rel Ok. Retrieving master addresses from leader master using RPC request. http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@154 PS4, Line 154: , &resp, > It would help to have more information on the error per each record (e.g., Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@155 PS4, Line 155: > This should be std::cerr, or maybe use LOG() instead. Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@155 PS4, Line 155: : if (resp.has_error()) { > For better readability, use Substitute() here instead. Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@790 PS4, Line 790: most common configu > This sub-command is already in the "master" context, so maybe rename this t Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_master.cc@791 PS4, Line 791: iguration options p > nit: for all Kudu Masters in the cluster Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc@152 PS4, Line 152: LOG(WARNING) > It would be great to see what was the error for each of these (e.g., adding Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc@152 PS4, Line 152: Substitute("Set config {$0:$1} for $2 failed, error message: $1", : flag, value, addr, s.ToString()); > For better readability, consider using Substitute() instead. Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc@157 PS4, Line 157: Tablet > nit (try to keep the same terms in the output): Tablet Server Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc@429 PS4, Line 429: set_flag_for_all", &T > That's already tserver's context (kudu tserver <sub-command>), so maybe ren Done http://gerrit.cloudera.org:8080/#/c/18506/4/src/kudu/tools/tool_action_tserver.cc@430 PS4, Line 430: for all Kudu Tablet Server > nit: for all Kudu Tablet Servers in the cluster Done -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 11:00:43 +0000 Gerrit-HasComments: Yes
