Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: Batch set master/tserver flags ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8137 PS1, Line 8137: out.clear(); Seems 'out' is not used here, you can pass a nullptr to RunActionStdoutString, or use RunActionStdoutNone instead. http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8138 PS1, Line 8138: opts.num_masters If going to get tserver flags, loop by opts.num_masters is meaningless. http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8150 PS1, Line 8150: vector<string> configs = Split(out, flag_key, strings::SkipEmpty()); : vector<string> values = Split(configs[1], "|", strings::SkipEmpty()); : string fvalue = values[1]; : auto itor = remove_if(fvalue.begin(), : fvalue.end(), ::isspace); : fvalue.erase(itor, fvalue.end()); : ASSERT_TRUE(fvalue == flag_value); Seems too complex to parse the output, you can improve the output in another patch, for example, output in JSON format. http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@150 PS1, Line 150: std::cout << "Address: " << addr << " config: {" How about use LOG(WARNING) ? http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@154 PS1, Line 154: return Status::OK(); If any tserver set failed, do not return OK. http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@428 PS1, Line 428: .Build(); nit: remove these tail spaces. -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 02:44:06 +0000 Gerrit-HasComments: Yes
