Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18506 )
Change subject: [Config] Set all masters/tservers flags in a cluster in batch mode ...................................................................... Patch Set 4: (8 comments) > Patch Set 4: > > (16 comments) http://gerrit.cloudera.org:8080/#/c/18506/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18506/1//COMMIT_MSG@7 PS1, Line 7: [Config] Set all masters/tservers flags in a cluster in batch mode > nit: Could you please add some description about what tools have been added Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8137 PS1, Line 8137: > Seems 'out' is not used here, you can pass a nullptr to RunActionStdoutStri Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8138 PS1, Line 8138: aster? opts.num_ > If going to get tserver flags, loop by opts.num_masters is meaningless. Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/kudu-tool-test.cc@8150 PS1, Line 8150: &out)); : } : rapidjson::Document doc; : doc.Parse<0>(out.c_str()); : for (int i = 0; i < doc.Size(); i++) { : const rapidjson::Value& item = doc[i]; : assert(item["flag"].IsString()); > Seems too complex to parse the output, you can improve the output in anothe Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_master.cc@793 PS1, Line 793: .AddRequiredParameter({ kValueArg, "New value for the gflag" }) > Maybe we also need to provide an optional parameter 'force' here just as th Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@150 PS1, Line 150: if (!s.ok()) { > How about use LOG(WARNING) ? Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@154 PS1, Line 154: } > If any tserver set failed, do not return OK. Done http://gerrit.cloudera.org:8080/#/c/18506/1/src/kudu/tools/tool_action_tserver.cc@428 PS1, Line 428: unique_ptr<Action> set_all_tservers_flag = > nit: remove these tail spaces. Done -- To view, visit http://gerrit.cloudera.org:8080/18506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33ce35389590c362d6167c677a7a3a28e08c040f Gerrit-Change-Number: 18506 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 11 May 2022 07:08:02 +0000 Gerrit-HasComments: Yes
