Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support enable/disable auto rebalancer online ...................................................................... Patch Set 9: (2 comments) Thanks you crs very much. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@192 PS9, Line 192: return thread_token_->Schedule([this]() { this->RunLoop(); }, > If the task has been put into thread_token_, even if we set --auto_rebalanc Yes. In future, it will check the flag as below (line 199) when it runs. Yes. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@199 PS9, Line 199: if (!FLAGS_auto_rebalancing_enabled) { > Can we implement it like: The style also a thread' implement, and no my intent, In fact, I am thinking remove the shutdown_. As the implements, the task always occupy the thread of threadpool. I want to change it, All the alone thread can be replaced by the thread pool. We can discuss it again. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 9 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 08 Jul 2022 14:13:34 +0000 Gerrit-HasComments: Yes
