Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 15: (4 comments) Thanks a lot. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@179 PS9, Line 179: ager_->sche > nit: it's too puzzle to me. This is base 9. the lastest is base 14 http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@180 PS9, Line 180: ken_ = t > NextLoop() { Yes. This is an opinions differ. This is the first refact using the SchedulerThread. And I refact it a little to make it more look nicer. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@190 PS9, Line 190: > nit: The function name is a bit of puzzle, better to improve it. Done http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@199 PS9, Line 199: 1000 * FLAGS_auto_rebalancing_interval_seconds); > Could you describe the profits we can get from the refactor? There are many independent, Idle and isolated threads not participant in threadpool. We can use less threads, unfied threadpool to manager them. Easily logic codes and unfiefd code style after more Deeper refactoring. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 06:49:33 +0000 Gerrit-HasComments: Yes
