Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@179 PS9, Line 179: ager_->sche nit: it's too puzzle to me. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@180 PS9, Line 180: ken_ = t NextLoop() { thread_token_->Schedule([this]() { this->RunLoop(); }, ..); } RunLoop() { .. NextLoop(); .. NextLoop(); do_work(); } IMO, it's not better than the old style. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@190 PS9, Line 190: nit: The function name is a bit of puzzle, better to improve it. http://gerrit.cloudera.org:8080/#/c/18679/9/src/kudu/master/auto_rebalancer.cc@199 PS9, Line 199: > The style also a thread' implement, and no my intent, In fact, I am thinkin Could you describe the profits we can get from the refactor? -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 14 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 09:35:04 +0000 Gerrit-HasComments: Yes
