Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@227 PS15, Line 227: thread nit: threads http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@227 PS15, Line 227: that nit: than http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@229 PS15, Line 229: MutexLock auto_lock(running_lock_); IMO it's not needed to schedule the rebalance tasks so frequently step by step, if you find a task is running, just return? http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/auto_rebalancer.cc@237 PS15, Line 237: std:: nit: has been 'using std::nullopt', ' std::' can be omit. http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18679/15/src/kudu/master/catalog_manager.cc@161 PS15, Line 161: DEFINE_int32(scheduler_pool_max_thread_num, 4, "max thread numbers of scheduler thread pool"); Better to describe what type od tasks this thread pool used to run. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 15 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 08:01:26 +0000 Gerrit-HasComments: Yes
