Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/18732/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18732/3//COMMIT_MSG@13 PS3, Line 13: MR nit: patch http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/kudu-tool-test.cc@8151 PS3, Line 8151: NO_FATALS(CreateTableWithFlushedData("table1", mini_cluster_.get(), 3)); : NO_FATALS(CreateTableWithFlushedData("table2", mini_cluster_.get(), 3)); nit: It suggest to explict set the 4th parameter (num_replicas) to 1 to clearify the two tservers have different replicas. http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/kudu-tool-test.cc@8176 PS3, Line 8176: find(target_tablet_ids.begin(), target_tablet_ids.end(), tablet_id) : != target_tablet_ids.end() nit: ContainsKey(target_tablet_ids, tablet_id); http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/tool_action_local_replica.cc@450 PS3, Line 450: std::unique_ptr nit: unique_ptr http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/tool_action_local_replica.cc@451 PS3, Line 451: clone-pool nit: how about keep the same style with CopyFromLocal ? i.e. tool-tablet-copy-pool http://gerrit.cloudera.org:8080/#/c/18732/3/src/kudu/tools/tool_action_local_replica.cc@466 PS3, Line 466: if (!s.ok()) break; Use the same method to refactor code as it in CopyFromLocal, i.e. use AndThen. -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 08:48:03 +0000 Gerrit-HasComments: Yes
