Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 8: (4 comments) > Patch Set 7: > > (5 comments) http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tablet/tablet_replica.h File src/kudu/tablet/tablet_replica.h: http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tablet/tablet_replica.h@111 PS7, Line 111: TabletReplica(); > Why change this? Construction function: TabletReplica() is private before?we cannot use it directly in function: CopyTablets() http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tools/tool_action_local_replica.cc@272 PS7, Line 272: TabletCopyClient* client; > There is only two types, and seems impossible to add the 3rd one, so I thin Done http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tools/tool_action_local_replica.cc@281 PS7, Line 281: tCopyCl > fake_replica can be used to check the copy progess, you can use it as in lo Done http://gerrit.cloudera.org:8080/#/c/18732/7/src/kudu/tools/tool_action_local_replica.cc@565 PS7, Line 565: > nit: this paramter can be omitted, and you can use this flag in the new add Done -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 02:36:18 +0000 Gerrit-HasComments: Yes
