Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 7: (5 comments) > Patch Set 6: > > (6 comments) http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@420 PS6, Line 420: if (tablet_ids.empty()) { > I found there are some duplicate code both in CopyFromLocal and CopyFromRem Done http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@443 PS6, Line 443: cons > nit: copy tool Done http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@444 PS6, Line 444: er->env(); > nit: tool-tablet-copy-pool Done http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@450 PS6, Line 450: cmet > nit: copy Done http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@465 PS6, Line 465: > The error details has been logged in the line above, is it neccesary to col Done -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 21 Jul 2022 10:38:00 +0000 Gerrit-HasComments: Yes
