Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@420 PS6, Line 420: Status CopyFromRemote(const RunnerContext& context) { I found there are some duplicate code both in CopyFromLocal and CopyFromRemote, is it possible to do some refactor to reuse some code? http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@443 PS6, Line 443: clone_pool nit: copy tool http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@444 PS6, Line 444: tool-tablet-copy-pool-pool nit: tool-tablet-copy-pool http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@450 PS6, Line 450: clone nit: copy http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@457 PS6, Line 457: return client.FetchAll(nullptr); could you please add an extra thread to check the copy progress, it would be helpful if the copied replica is very large which would cost long time to copy. Similar to CopyFromLocal. http://gerrit.cloudera.org:8080/#/c/18732/6/src/kudu/tools/tool_action_local_replica.cc@465 PS6, Line 465: s The error details has been logged in the line above, is it neccesary to collect and log it again? -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 20 Jul 2022 03:38:02 +0000 Gerrit-HasComments: Yes
