Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18732 )

Change subject: [Tools] Copy tablets from a remote server in batch
......................................................................


Patch Set 16:

(3 comments)

> Patch Set 13:
>
> (3 comments)

http://gerrit.cloudera.org:8080/#/c/18732/13/src/kudu/tablet/tablet_replica.h
File src/kudu/tablet/tablet_replica.h:

http://gerrit.cloudera.org:8080/#/c/18732/13/src/kudu/tablet/tablet_replica.h@26
PS13, Line 26: #include <string>
> nit: outdated, remove it
Done


http://gerrit.cloudera.org:8080/#/c/18732/13/src/kudu/tablet/tablet_replica.h@87
PS13, Line 87: amespace too
> nit: TabletCopier
Done


http://gerrit.cloudera.org:8080/#/c/18732/13/src/kudu/tools/tablet_copyer.h
File src/kudu/tools/tablet_copyer.h:

http://gerrit.cloudera.org:8080/#/c/18732/13/src/kudu/tools/tablet_copyer.h@1
PS13, Line 1:
> implement this class in tool_action_local_replica.cc is enough, no need to
Done



--
To view, visit http://gerrit.cloudera.org:8080/18732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664
Gerrit-Change-Number: 18732
Gerrit-PatchSet: 16
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 27 Jul 2022 01:50:43 +0000
Gerrit-HasComments: Yes

Reply via email to