Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 16: (8 comments) http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@96 PS16, Line 96: namespace tools { can be removed? http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@173 PS16, Line 173: using kudu::tools::TabletCopier; can be removed? http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@217 PS16, Line 217: set<string>* use common object, and you can std::move it in cstor, which is the google code style and used in Kudu http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@220 PS16, Line 220: HostPort* same http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@225 PS16, Line 225: copy_type_ = CopyType::FROM_REMOTE; you can also init it in cstor init-list http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@228 PS16, Line 228: std:: can be omitted http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@328 PS16, Line 328: delete client how about use unique_ptr? http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@359 PS16, Line 359: enum better to use enum class -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 03:56:53 +0000 Gerrit-HasComments: Yes
