Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 17: (8 comments) > Patch Set 16: > > (8 comments) http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@96 PS16, Line 96: namespace rpc { > can be removed? Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@173 PS16, Line 173: using kudu::tserver::TSTabletManager; > can be removed? Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@217 PS16, Line 217: tablet_id > use common object, and you can std::move it in cstor, which is the google c Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@220 PS16, Line 220: source > same Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@225 PS16, Line 225: FsManager* dst_fs_manage > you can also init it in cstor init-list Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@228 PS16, Line 228: set<s > can be omitted Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@328 PS16, Line 328: LOG(INFO) > how about use unique_ptr? Done http://gerrit.cloudera.org:8080/#/c/18732/16/src/kudu/tools/tool_action_local_replica.cc@359 PS16, Line 359: FsMa > better to use enum class Done -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 10:52:02 +0000 Gerrit-HasComments: Yes
