Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18732 )
Change subject: [Tools] Copy tablets from a remote server in batch ...................................................................... Patch Set 17: (2 comments) the failed test is related, have to fix it before mergering. http://gerrit.cloudera.org:8080/#/c/18732/17/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18732/17/src/kudu/tools/tool_action_local_replica.cc@311 PS17, Line 311: dst_cmeta_manager_, /* messenger */ nullptr, : &tablet_copy_client_metrics, src_fs_manager_, : /* tablet_copy_source_metrics */ nullptr)); nit: alignment http://gerrit.cloudera.org:8080/#/c/18732/17/src/kudu/tools/tool_action_local_replica.cc@630 PS17, Line 630: &dst_fs_manager, : move(dst_cmeta_manager), : &src_fs_manager, : move(src_tablet_ids_set)); nit: alignment -- To view, visit http://gerrit.cloudera.org:8080/18732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib598142883b8ab958625a4f04648d58ea95f3664 Gerrit-Change-Number: 18732 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 30 Jul 2022 07:45:00 +0000 Gerrit-HasComments: Yes
