Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/18679/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18679/22//COMMIT_MSG@12 PS22, Line 12: This patch supports to use gflag --auto_rebalancing_enabled to control nit: Add: TAG_FLAG(auto_rebalancing_enabled, runtime); to the place where auto_rebalancing_enabled defined. http://gerrit.cloudera.org:8080/#/c/18679/22/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18679/22/src/kudu/master/auto_rebalancer.h@173 PS22, Line 173: auto submit rebalancing. how about: The token where AutoRebalancerTasks will be submitted to. http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc@228 PS20, Line 228: (!rebalancer_running_.compare_exchange_strong( > Next pach, I want to support another method running rebalance by kudu CLI, It's another story. Curently it's not needed, you can add it back in the next patch. http://gerrit.cloudera.org:8080/#/c/18679/22/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/22/src/kudu/master/auto_rebalancer.cc@188 PS22, Line 188: if (thread_token_) { : ThreadPoolToken* token = thread_token_.release(); : delete token; : token = nullptr; : } how about: thread_token_.reset(); directly? -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 22 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 10:10:58 +0000 Gerrit-HasComments: Yes
