Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 21: (7 comments) Thanks your crs. http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.h@81 PS20, Line 81: Status ScheduleRebalance(); : : // Runs the main loop of the auto-rebalancing task. : void Rebalance(); : : Status DoReplicaR > The 3 function names really puzzled me a bit :) Fix them, do my best. http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.h@179 PS20, Line 179: running > nit: running Done http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc@179 PS20, Line 179: n_ = c > nit: can be omitted? Done http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc@191 PS20, Line 191: delete token; : token = nullptr; : } : } > why not use unique_ptr? Done http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/auto_rebalancer.cc@228 PS20, Line 228: tic bool negtive_bool = false; > 'SERIAL type token tasks are run one at a time', how the situation you desc Next pach, I want to support another method running rebalance by kudu CLI, Only auto leader rebalance the protect is not necessary. In that way, service reactor thread would invoke 'ReplicaRebalance' directly. http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/master/catalog_manager.h@1254 PS20, Line 1254: // The thread pool can be used to schedule async execute a delay task or > nit: Add some description what does this pool do. ok http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/18679/20/src/kudu/util/threadpool-test.cc@198 PS20, Line 198: } > remove these meanless blank lines Done -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 21 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 09:19:52 +0000 Gerrit-HasComments: Yes
