Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 24: (12 comments) http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG@7 PS24, Line 7: turn turning http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG@9 PS24, Line 9: has supported supports http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG@12 PS24, Line 12: This patch supports to use gflag --auto_rebalancing_enabled to control : whether turn on/off auto-rebalancer when running. Try to rephrase this, maybe? http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG@17 PS24, Line 17: Easily logic codes ? http://gerrit.cloudera.org:8080/#/c/18679/24//COMMIT_MSG@18 PS24, Line 18: refacting refactoring? http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.h@81 PS24, Line 81: Status ScheduleRebalance(); Add a blurb explaining an essence of what this method does. http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.h@86 PS24, Line 86: Status DoReplicaRebalance(); Add a blurb explaining the essence of what this method does. http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.cc@175 PS24, Line 175: scheduler pool is not initialized This is supposed to be a message that describes a problem -- it prints out when the assertion fails. The essence of this http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.cc@179 PS24, Line 179: CHECK_OK Why CHECK_OK() instead of RETURN_NOT_OK()? http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/catalog_manager.h@1254 PS24, Line 1254: execute a delay task execution of a delayed task http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/catalog_manager.h@1254 PS24, Line 1254: can be used Please outline what this is actually used for, not what it can be used for. http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/catalog_manager.h@1255 PS24, Line 1255: implement period tasks run periodic tasks -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 24 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 17:37:54 +0000 Gerrit-HasComments: Yes
