Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18679 )
Change subject: [master] support turn on/off auto rebalancer at runtime ...................................................................... Patch Set 24: Code-Review+1 (3 comments) looks good to me except some nits. http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer-test.cc@303 PS24, Line 303: SleepFor(MonoDelta::FromSeconds(3)); there is a sleep in ASSERT_EVENTUALLY, it's not needed to sleep manually. http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer-test.cc@312 PS24, Line 312: } can we use CheckNoMovesScheduled and/or CheckSomeMovesScheduled instead? http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/18679/24/src/kudu/master/auto_rebalancer.cc@188 PS24, Line 188: if (scheduler_pool_token_) { : scheduler_pool_token_.reset(); : } nit: I meant we can use scheduler_pool_token_.reset(); directly, it's safe to reset an uninitilized unique_ptr. -- To view, visit http://gerrit.cloudera.org:8080/18679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbcea6392b783843f89e019f1141dd8905366de5 Gerrit-Change-Number: 18679 Gerrit-PatchSet: 24 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 27 Jul 2022 16:33:41 +0000 Gerrit-HasComments: Yes
