Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 14: (3 comments) > Patch Set 12: > > Thanks for the patch. Will be useful while debugging. > 1. Will there be an equivalent java version of the patch coming as we would > want to have the same behavior in both the clients? > 2. Also I was under the impression that impala uses Kudu java client to talk > to Kudu. Can you confirm if these changes are tested end to end? Thx. Impala gets metadata from Kudu using java client not query. But anyway, java client is also need to support request id. http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc@93 PS9, Line 93: next_req_.set_request_id(oid_generator.Next()); > So, is it meaningful to add a random request id in this situation? Is there It is meaningful. Maybe it can not make a relationship with Impala request, but it can make a relationship with all tablet reading by the random request id. And it also can make a relationship with Impala request by timestamp and this random request id. http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc@2874 PS12, Line 2874: NewScanRequestPB* scan = req.mutable_new_scan_request(); > nit: move them closer to the place where you use them Done http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc@2883 PS12, Line 2883: { > Is it possible to check the request id is actual dealt on server side? For It is difficult. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 14 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 14 Sep 2022 11:27:44 +0000 Gerrit-HasComments: Yes
