Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 11: (3 comments) > Patch Set 9: > > (3 comments) > > I see the test is check the client side, how to verify that it works in > server side? Add a new server side test. http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/client-test.cc@616 PS9, Line 616: KuduScanner scanner(client_table_.get(), move(request_id)); > what's the purpose of using unique_ptr? Done http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/client-test.cc@1136 PS9, Line 1136: > nit: how about using const string? Done http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc@93 PS9, Line 93: next_req_.set_request_id(oid_generator.Next()); > If the caller create multiple KuduScanners in a single query without pass a Yes. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 09 Sep 2022 09:44:12 +0000 Gerrit-HasComments: Yes
