Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/18846/9/src/kudu/client/scanner-internal.cc@93 PS9, Line 93: next_req_.set_request_id(oid_generator.Next()); > Yes. So, is it meaningful to add a random request id in this situation? Is there any difference to not add request id? http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc@2874 PS12, Line 2874: ScanResponsePB resp; nit: move them closer to the place where you use them http://gerrit.cloudera.org:8080/#/c/18846/12/src/kudu/tserver/tablet_server-test.cc@2883 PS12, Line 2883: // Send the call Is it possible to check the request id is actual dealt on server side? For example, it appears in server log? -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 12 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 11 Sep 2022 00:36:01 +0000 Gerrit-HasComments: Yes
