Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19024 )
Change subject: KUDU-3403 Enable kudu cli to accept specific leader to step down ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/19024/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19024/4//COMMIT_MSG@9 PS4, Line 9: Accept leader uuid as an argument to identify the leader Adding a 'current_leader_uuid' gflag for Kudu CLI may be not good enough. Because it need kudu administrators' judgement, they should find the real leader uuid and input it, administors may write an error current leader uuid. Althought they can retry another one uuid, but it's cost time complex ops. In fact, an error current_leader_uuid is not confluence to kudu cluster. So IMO, if kudu CLI get master' leader not the real one, kudu CLI can retry the next one voter maybe it is the real leader, if not, continue retry the next one until the last voter. http://gerrit.cloudera.org:8080/#/c/19024/4/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19024/4/src/kudu/tools/tool_action_tablet.cc@175 PS4, Line 175: return s.CloneAndPrepend( nit: 2 space characters http://gerrit.cloudera.org:8080/#/c/19024/4/src/kudu/tools/tool_action_tablet.cc@176 PS4, Line 176: Substitute("unable to transfer leadership to $0", *new_leader_uuid)); what about, unable to transfer leadership to $0 because of no such current_leader_uuid $1 http://gerrit.cloudera.org:8080/#/c/19024/4/src/kudu/tools/tool_action_tablet.cc@192 PS4, Line 192: return s.CloneAndPrepend( nit: 2 space characters -- To view, visit http://gerrit.cloudera.org:8080/19024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40569faa40a8173c51504c7567aa84a6ae1fb64a Gerrit-Change-Number: 19024 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 25 Sep 2022 10:05:31 +0000 Gerrit-HasComments: Yes
