Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19024 )
Change subject: KUDU-3403 Enable kudu cli to accept specific leader to step down ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19024/5/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19024/5/src/kudu/tools/tool_action_tablet.cc@342 PS5, Line 342: .AddOptionalParameter("current_leader_uuid") > As I understand, the 'new_leader_uuid' field (that's the field you are refe Yes, new_leader_uuid as well as other parameters like abrupt. >From your explanation, it seems that my understanding is incorrect. I was >under the impression that while the request is sent to the leader, along with >that all the parameters including current_leader_uuid are also packed. So, it would be safe to say that we don't need current_leader_uuid as extra field in LeaderStepDownRequestPB as there will not be a case wherein we need to send current_leader_uuid as part of request payload. -- To view, visit http://gerrit.cloudera.org:8080/19024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40569faa40a8173c51504c7567aa84a6ae1fb64a Gerrit-Change-Number: 19024 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 11 Oct 2022 17:05:30 +0000 Gerrit-HasComments: Yes
