Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19024 )
Change subject: KUDU-3403 Enable kudu cli to accept specific leader to step down ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (4 comments) http://gerrit.cloudera.org:8080/#/c/19024/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19024/4//COMMIT_MSG@9 PS4, Line 9: Accept leader uuid as an argument to identify the leader > Adding a 'current_leader_uuid' gflag for Kudu CLI may be not good enough. Purpose of adding this flag is to enable user/admin to be able to transfer leadership from current leader if master is out of sync. Even though, this could be a rare scenario but it is possible and in such situations, having an additional flag makes more sense that would provide flexibility admin to choose the right current leader. If we go choose retry approach, we would end up iterating through all the nodes and keep issuing 'step down' for each until we reach actual leader, and this would change the behavior of existing logic where we find the leader from master and transferring leadership from it. Changing this behavior may also be required changing the test cases (if any) that try create 'master out of sync' scenario and expect an error when 'step down' is issued. Having a separate flag to denote current leader would give admin option to specify one, presumably the correct one most of the times. Even if a wrong current leader is input, Kudu CLI throws the appropriate error. -- To view, visit http://gerrit.cloudera.org:8080/19024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40569faa40a8173c51504c7567aa84a6ae1fb64a Gerrit-Change-Number: 19024 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 12:07:24 +0000 Gerrit-HasComments: Yes
