Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19024 )
Change subject: KUDU-3403 Enable kudu cli to accept specific leader to step down ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19024/5/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19024/5/src/kudu/tools/tool_action_tablet.cc@342 PS5, Line 342: .AddOptionalParameter("current_leader_uuid") > I noticed that a new flag added to leader step down CLI also makes its way As I understand, the 'new_leader_uuid' field (that's the field you are referring to, right?) was introduced to be able to transfer leadership directly to the specified replica. As for the 'current_leader_uuid', IIRC, the step down is implemented that way that first a Raft leader is found just before the request is sent out, and then the request is sent to the leader. What's the idea behind adding 'current_leader_uuid' as an extra field to the LeaderStepDownRequestPB? -- To view, visit http://gerrit.cloudera.org:8080/19024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40569faa40a8173c51504c7567aa84a6ae1fb64a Gerrit-Change-Number: 19024 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 11 Oct 2022 16:35:45 +0000 Gerrit-HasComments: Yes
