Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19203 )
Change subject: [KUDU-3419][TabletManager] Fix the stuck of tablet server when starting ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.cc@1586 PS4, Line 1586: void TSTabletManager::GetLocalTabletReplicas( : vector<scoped_refptr<TabletReplica> >* replicas) const { : shared_lock<RWMutex> l(lock_); : AppendValuesFromMap(tablet_map_, replicas); : } : : void TSTabletManager::GetTabletReplicas(vector<scoped_refptr<TabletReplica> >* replicas) const { : shared_lock<RWMutex> l(lock_); : AppendValuesFromMap(tablet_map_, replicas); : } : > Is there any difference between the 2 functions? No difference. GetTabletReplicas is virtual, so it can be not used in deconstruct function: ~TSTabletManager(). -- To view, visit http://gerrit.cloudera.org:8080/19203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9a4f4158fcb0a36499345e00ee72c65f5fefe0 Gerrit-Change-Number: 19203 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 07 Nov 2022 02:24:30 +0000 Gerrit-HasComments: Yes
