Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19203 )
Change subject: [KUDU-3419] Fix the stuck of tablet server when starting ...................................................................... Patch Set 6: (4 comments) Any chance to add a test for this to catch regressions in the future? http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG Commit Message: PS4: > Could you reformat the commit message a bit? Please follow the guide at ht Missed this? http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG@12 PS4, Line 12: its > If tablet server does not finished initiation, UnregisterAllServices() will Right, but the idea was to update that code appropriately. OK, if you think it's not worth it, the current approach is good to fix the issue. http://gerrit.cloudera.org:8080/#/c/19203/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19203/6//COMMIT_MSG@8 PS6, Line 8: : If the permission of tablet metadata file is denied when tablet server starting, : tablet server will get stuck and can not exit automatically. That is because : if the permission is denied, the object of TabletServer will be deconstructed, : it will deconstruct its thread pool:txn_status_manager_pool_, but this thread : pool contains a task: TxnStalenessTrackerTask, the task is still running. : There are no code to shutdown the task in that case. Therefore tablet server : will get stuck. Could you reformat the commit message a bit? Please follow the guide at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines that can be found at the https://kudu.apache.org/docs/contributing.html#_submitting_patches page. In essence, strive to keep the lines in the description to be at most 72 characters long. http://gerrit.cloudera.org:8080/#/c/19203/6/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/19203/6/src/kudu/tserver/ts_tablet_manager.h@293 PS6, Line 293: nit: there should be 4 spaces indent here, see the code style guide https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions -- To view, visit http://gerrit.cloudera.org:8080/19203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9a4f4158fcb0a36499345e00ee72c65f5fefe0 Gerrit-Change-Number: 19203 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:55:00 +0000 Gerrit-HasComments: Yes
