Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19203 )
Change subject: [KUDU-3419] Fix the stuck of tablet server when starting ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG@7 PS4, Line 7: [KUDU-3419] Fix the stuck > nit: use either 'KUDU-3419: ...' or '[TabletManager] ...', but not both Done http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG@12 PS4, Line 12: its > its If tablet server does not finished initiation, UnregisterAllServices() will failed, because messenger_ is nlullptr http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG@14 PS4, Line 14: There are no code to shutdown the task i > nit: There was no code to shutdown the task in that case. Done http://gerrit.cloudera.org:8080/#/c/19203/4//COMMIT_MSG@15 PS4, Line 15: will get stuck. > nit: See KUDU-3419 for details. Done http://gerrit.cloudera.org:8080/#/c/19203/5/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/19203/5/src/kudu/tserver/ts_tablet_manager.h@200 PS5, Line 200: // next round of master heartbeats. > Leave a blank line between the function and the next function (comments) Done http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.h@196 PS4, Line 196: void GetTabletReplicas( : std::vector<scoped_refptr<tablet::TabletReplica>>* replicas) const o > Make this method private and call it in the implementation of the GetTablet Done http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.h@200 PS4, Line 200: > nit: remove -- contemporary C++ compilers don't require this extra space Done http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/19203/4/src/kudu/tserver/ts_tablet_manager.cc@553 PS4, Line 553: LOG_AND_RETURN(ERROR, first_error); > I guess this should have become Done -- To view, visit http://gerrit.cloudera.org:8080/19203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9a4f4158fcb0a36499345e00ee72c65f5fefe0 Gerrit-Change-Number: 19203 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 11:52:59 +0000 Gerrit-HasComments: Yes
