Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19203 )

Change subject: [KUDU-3419] Fix the stuck of starting tablet server
......................................................................


Patch Set 7:

(2 comments)

> Patch Set 6:
>
> (4 comments)
>
> Any chance to add a test for this to catch regressions in the future?

http://gerrit.cloudera.org:8080/#/c/19203/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19203/6//COMMIT_MSG@8
PS6, Line 8:
           : If the permission of tablet metadata file is denied when
           : tablet server starting,tablet server will get stuck and
           : can not exit automatically. That is because if the permission
           : is denied, the object of TabletServer will be deconstructed,
           : it will deconstruct its thread pool:txn_status_manager_pool_,
           : but this thread pool contains a task: TxnStalenessTrackerTask,
           : the task is sti
> Could you reformat the commit message a bit?  Please follow the guide at ht
Done


http://gerrit.cloudera.org:8080/#/c/19203/6/src/kudu/tserver/ts_tablet_manager.h
File src/kudu/tserver/ts_tablet_manager.h:

http://gerrit.cloudera.org:8080/#/c/19203/6/src/kudu/tserver/ts_tablet_manager.h@293
PS6, Line 293:
> nit: there should be 4 spaces indent here, see the code style guide https:/
Done



--
To view, visit http://gerrit.cloudera.org:8080/19203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c9a4f4158fcb0a36499345e00ee72c65f5fefe0
Gerrit-Change-Number: 19203
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Thu, 10 Nov 2022 01:50:56 +0000
Gerrit-HasComments: Yes

Reply via email to