Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/client_negotiation.h@191 PS9, Line 191: std::unique_ptr<ErrorStatusPB> *rpc_error) WARN_UNUSED_RESULT nit: alignment http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/messenger.cc@325 PS9, Line 325: SimpleJwtVerifier why use the dummy verifier? http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/util/jwt.h File src/kudu/util/jwt.h: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/util/jwt.h@31 PS9, Line 31: VerifyToken add a comment for the functionality provided by this function, including input/output parameters -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:44:07 +0000 Gerrit-HasComments: Yes
