Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/18469/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18469/8//COMMIT_MSG@10 PS8, Line 10: It is limited in the sense that JWTs can be sent over unencrypted : channels -- this should be addressed before using in production. > Has this been addressed in any of the follow-up patches yet? Not yet http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/client_negotiation.h@191 PS9, Line 191: std::unique_ptr<ErrorStatusPB> *rpc_error) WARN_UNUSED_RESULT > nit: alignment Done http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/rpc/messenger.cc@325 PS9, Line 325: SimpleJwtVerifier > why use the dummy verifier? This is basically a stand-in for a default value. In a later commit, the messenger builder is used to set the proper verifier: https://gerrit.cloudera.org/c/18471/3/src/kudu/server/server_base.cc#657 http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/util/jwt.h File src/kudu/util/jwt.h: http://gerrit.cloudera.org:8080/#/c/18469/9/src/kudu/util/jwt.h@31 PS9, Line 31: VerifyToken > add a comment for the functionality provided by this function, including in Done -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 18:01:00 +0000 Gerrit-HasComments: Yes
