Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18469/10/src/kudu/util/jwt.h File src/kudu/util/jwt.h: http://gerrit.cloudera.org:8080/#/c/18469/10/src/kudu/util/jwt.h@29 PS10, Line 29: public: : virtual ~JwtVerifier() {} Follow the coding style, add one space before "public", leave two space before "virtual...". http://gerrit.cloudera.org:8080/#/c/18469/10/src/kudu/util/jwt.h@32 PS10, Line 32: subject Please declare the owner ship for returned the pointer. Does the caller need to free the memory? -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 18:26:43 +0000 Gerrit-HasComments: Yes
