Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 13: (2 comments) Could you add new unit test for jwt? http://gerrit.cloudera.org:8080/#/c/18469/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18469/13//COMMIT_MSG@10 PS13, Line 10: It is limited in the sense that JWTs can be sent over unencrypted : channels In ServerNegotiation::AuthenticateByJwt(), you already added sanity check which check if TLS has been negotiated. http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/server_negotiation.cc@717 PS13, Line 717: nit: indent -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 13 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 22:47:58 +0000 Gerrit-HasComments: Yes
