Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 32: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@305 PS32, Line 305: GetCountMapByUuid nit: What about GetSelectedReplicaCount? http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@308 PS32, Line 308: Get the closest replica from the same client twice and ensure they match nit: Irrelevant comments. http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@328 PS32, Line 328: ScannerCountMap nit: What about GetScannerCount? -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 32 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 16 Nov 2022 14:41:17 +0000 Gerrit-HasComments: Yes
