Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 33: (6 comments) Thank you for your advices. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@205 PS18, Line 205: return Status::OK(); > Is this used at all? Maybe I do not reply it. It's removed. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@205 PS18, Line 205: n Status::OK(); > Sorry, That's medium code. I'll remove it. Done http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc@1683 PS29, Line 1683: > In addition to relying to implementation details, CLOSEST_REPLICA selection According to Yifan's advice, I have refactored the codes recently, that's a deterministic case, you can review it again. The method what you say seems good, I'll study it. If it's better than mine, I'll change it in future. I'll add a TODO for this. http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@305 PS32, Line 305: GetSelectedReplic > nit: What about GetSelectedReplicaCount? Done http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@308 PS32, Line 308: (const auto& tablet_id : tablet_ids) { > nit: Irrelevant comments. Done http://gerrit.cloudera.org:8080/#/c/18877/32/src/kudu/client/scan_token-test.cc@328 PS32, Line 328: nner_count_by_t > nit: What about GetScannerCount? Done -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 33 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 10:44:34 +0000 Gerrit-HasComments: Yes
