Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 29: (2 comments) http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@205 PS18, Line 205: return Status::OK(); Is this used at all? http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc@1683 PS29, Line 1683: ASSERT_GT(distinct_machine, 0); > Done In addition to relying to implementation details, CLOSEST_REPLICA selection might be tested by defining locations in the cluster and assigning location to the client as well. CLOSEST_REPLICA has an affinity for location, so if there are multiple tablet servers with different locations defined and client has location assigned as well, the client selects the tablet servers with the same location as its own (if there is a match). For an example, check this out: https://github.com/apache/kudu/blob/10efaf2c77dfe5e4474505e0267c583c011703be/src/kudu/integration-tests/location_assignment-itest.cc#L76-L150 -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 29 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 16 Nov 2022 19:33:09 +0000 Gerrit-HasComments: Yes
